Skip to content

Loosen up the dependency on backoff#2575

Merged
lzchen merged 4 commits intoopen-telemetry:mainfrom
teddylear:lax-backoff-dependency
Mar 31, 2022
Merged

Loosen up the dependency on backoff#2575
lzchen merged 4 commits intoopen-telemetry:mainfrom
teddylear:lax-backoff-dependency

Conversation

@teddylear
Copy link
Copy Markdown
Contributor

@teddylear teddylear commented Mar 29, 2022

Description

Updating backoff lib dependency for otpl-proto-grpc exporter to be more lax with version constraints.

Fixes #2384

@linux-foundation-easycla
Copy link
Copy Markdown

linux-foundation-easycla bot commented Mar 29, 2022

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: teddylear / name: teddylear (f092dd8)

@teddylear teddylear force-pushed the lax-backoff-dependency branch from f092dd8 to 566da97 Compare March 29, 2022 22:12
@teddylear teddylear changed the title [WIP] chore: edit otpl_proto-grpc dependencies to be more lax for backoff lib [WIP] chore: edit otpl-proto-grpc exporter dependencies to be more lax for backoff lib Mar 30, 2022
@teddylear teddylear marked this pull request as ready for review March 30, 2022 03:48
@teddylear teddylear requested a review from a team March 30, 2022 03:48
@teddylear teddylear changed the title [WIP] chore: edit otpl-proto-grpc exporter dependencies to be more lax for backoff lib chore: edit otlp-proto-grpc exporter dependencies to be more lax for backoff lib Mar 30, 2022
@srikanthccv
Copy link
Copy Markdown
Member

@teddylear Please do the same in proto-http exporter also.

@srikanthccv srikanthccv changed the title chore: edit otlp-proto-grpc exporter dependencies to be more lax for backoff lib Loosen up the dependency on backoff Mar 30, 2022
@teddylear
Copy link
Copy Markdown
Contributor Author

@srikanthccv will do 👍, I'll message when I've pushed an update.

@teddylear
Copy link
Copy Markdown
Contributor Author

@srikanthccv Updated with changes. Please let me know if there's anything else I should change. Thanks!

Copy link
Copy Markdown
Member

@srikanthccv srikanthccv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @teddylear

@lzchen lzchen merged commit b2e9387 into open-telemetry:main Mar 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Loosen up the dependency on backoff.

3 participants